Moti Asayag has posted comments on this change. Change subject: utils: Suppress warnings for deprecation and add appropriate TODO message ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33685/2/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java: Line 46: import org.w3c.dom.Node; Line 47: import org.w3c.dom.NodeList; Line 48: Line 49: // TODO refactor to avoid use of deprecated method VmNetworkInterface.setNetworkName Line 50: @SuppressWarnings("deprecation") please reduce the warning suppression for the usage of that method so other deprecation warning wouldn't be hidden. Line 51: public abstract class OvfReader implements IOvfBuilder { Line 52: protected OsRepository osRepository = SimpleDependecyInjector.getInstance().get(OsRepository.class); Line 53: protected ArrayList<DiskImage> _images; Line 54: protected ArrayList<VmNetworkInterface> interfaces; -- To view, visit http://gerrit.ovirt.org/33685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f5fe8816e006276fce3300ece657be8de21823f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tim Speetjens <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
