Alon Bar-Lev has posted comments on this change.

Change subject: core: protocol fall back for older vdsms
......................................................................


Patch Set 2:

I cannot review this.

But it looks over engineered... the protocol selection and fallback should be 
automatic behavior of core interaction with agent.

It should not be duplicated all over the code.

The user of agent communication layer should not care what protocol is used to 
interact with agent.

-- 
To view, visit http://gerrit.ovirt.org/33728
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6f48bec60b520c089f326f8c5e79aec288ff3d6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to