Alon Bar-Lev has posted comments on this change. Change subject: core: protocol fall back for older vdsms ......................................................................
Patch Set 2: the negotiation should be unrelated to cluster level. it should be only transport. the result of negotiation should be deterministic. if we used bad design and tied it to cluster level, there is no problem that the cluster level will be used as initialization (constructor) parameter to the agent, so that negotiation can be done using subset that matches the cluster level. in any case, modifying host-deploy class because of this is incorrect design. -- To view, visit http://gerrit.ovirt.org/33728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6f48bec60b520c089f326f8c5e79aec288ff3d6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
