Roy Golan has posted comments on this change. Change subject: core: prevent maintenance a host with hard affinity ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34060/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/VmAffinityFilterPolicyUnit.java: Line 74: Set<Guid> acceptableHosts = new HashSet<>(); Line 75: // Group all hosts for VMs with positive affinity Line 76: for (Guid id : allVmIdsPositive) { Line 77: VM runVm = runningVMsMap.get(id); Line 78: if (runVm != null && runVm.getRunOnVds() != null) { > causes regression. when migrating hostMap doesn't contain the RunOnVds host but what happens when our migrate will be more wise and we'll remove the canDo? Line 79: acceptableHosts.add(runVm.getRunOnVds()); Line 80: } Line 81: } Line 82: -- To view, visit http://gerrit.ovirt.org/34060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idd93ddca562bf739b2cd423e907be1b6da861735 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
