Selvasundaram has posted comments on this change.

Change subject: engine: Move Gluster host
......................................................................


Patch Set 3: (6 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
Line 92:                 
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_NO_GLUSTER_HOST_TO_PEER_PROBE);
Done

Line 129:         if 
(getVdsGroup(getParameters().getClusterId()).supportsGlusterService()) {
Done

Line 180:         if (getClusterUtils().hasServers(sourceClusterId)
Multiple Validation removed.

Line 211:                 
getReturnValue().getFault().setError(returnValue.getVdsError().getCode());
Done

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ClusterUtils.java
Line 65:     public boolean hasVolumeOnServer(Guid vdsId) {
Renamed the method and moved to new GlusterUtils.

....................................................
File 
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 525: GLUSTER_HOST_ADD_FAILED=Failed to add gluster server ${VdsName}.
Done

--
To view, visit http://gerrit.ovirt.org/5285
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24bd7d34c2312c34de63371912444c21b2896737
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to