Selvasundaram has posted comments on this change.
Change subject: engine: Move Gluster host
......................................................................
Patch Set 4: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
Line 88: if (getVdsGroup(getTargetClusterId()).supportsGlusterService()
Introduced sourceCluster and targeCluster members and respective get methods.
Which will hit db only once.
Line 103: private boolean hasUpServer(Guid clusterId) {
Done
Line 200: setSucceeded(returnValue.getSucceeded());
Done
Line 211: : getVds().gethost_name();
Yes, required for GlusterHostRemove as well.
Done.
Line 217: setSucceeded(returnValue.getSucceeded());
Done
--
To view, visit http://gerrit.ovirt.org/5285
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24bd7d34c2312c34de63371912444c21b2896737
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
