Francesco Romani has posted comments on this change. Change subject: core: removing CR char after encoding ......................................................................
Patch Set 4: Verified+1 verified the current patch by: - setting up on engine on centos 6.5 because I have already an half-baked development environment here, while I don't have it on RHEL 6.x. Actually, the only thing which matters is the apache-commons-codec jar is version 1.4 or lower - see here for the full story: http://gerrit.ovirt.org/#/c/34203/4//COMMIT_MSG,cm - build engine from branch 3.5.0 from scratch, added a couple of RHEL hosts (6.5 and 6.6), used defaults (JSON-RPC for everything but migrations), succesfully reproduced the issue - verified through virsh dumpxml and libvirtd logs - rebuilt patched engine - verified device path is identical on src and dst - verified through virsh dumpxml the image is attached on dest to device That said, I believe that even nicer fix is just replace encodeBase64String(content); with encodeBase64(content, false); which also matches the new default behaviour of apache-commons-codec >= 1.5 -- To view, visit http://gerrit.ovirt.org/34201 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c11ec26e25cf39084a889ec475f400a8318e5eb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
