Francesco Romani has posted comments on this change.
Change subject: core: removing CR char after encoding
......................................................................
Patch Set 5:
windows XP verification:
<devices>
<emulator>/usr/libexec/qemu-kvm</emulator>
<disk type='file' device='floppy'>
<driver name='qemu' type='raw'/>
<source
file='/var/run/vdsm/payload/9f800e53-b95b-4986-ba70-532216ffc700.4c62f60132670220c4e43f0bc9cddf98.img'
startupPolicy='optional'/>
<target dev='fda' bus='fdc'/>
<readonly/>
<serial></serial>
<alias name='fdc0-0-0'/>
<address type='drive' controller='0' bus='0' target='0' unit='0'/>
</disk>
TOji> 15:09:09 root [~]$ mount -o ro,loop
/var/run/vdsm/payload/9f800e53-b95b-4986-ba70-532216ffc700.4c62f60132670220c4e43f0bc9cddf98.img
/mnt/image/
TOji> 15:09:29 root [~]$ tree /mnt/image/
/mnt/image/
└── sysprep.inf
0 directories, 1 file
TOji> 15:09:32 root [~]$ cat /mnt/image/sysprep.inf
;SetupMgrTag
[Unattended]
InstallFilesPath=C:\i386
OemSkipEula=Yes
TargetPath=\WINDOWS
[GuiUnattended]
AdminPassword=xxx
EncryptedAdminPassword=NO
OEMSkipRegional=1
TimeZone=85
OemSkipWelcome=1
TOji> 15:10:07 root [~]$ file /mnt/image/sysprep.inf
/mnt/image/sysprep.inf: ASCII text, with CRLF line terminators
correctly passed on DST:
GENji> 15:13:47 root [~]$ mount -o ro,loop
/var/run/vdsm/payload/9f800e53-b95b-4986-ba70-532216ffc700.4c62f60132670220c4e43f0bc9cddf98.img
/mnt/image/
GENji> 15:13:59 root [~]$ file /mnt/image/sysprep.inf
/mnt/image/sysprep.inf: ASCII text, with CRLF line terminators
GENji> 15:14:02 root [~]$ head /mnt/image/sysprep.inf
;SetupMgrTag
[Unattended]
InstallFilesPath=C:\i386
OemSkipEula=Yes
TargetPath=\WINDOWS
[GuiUnattended]
AdminPassword=xxx
EncryptedAdminPassword=NO
OEMSkipRegional=1
--
To view, visit http://gerrit.ovirt.org/34201
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c11ec26e25cf39084a889ec475f400a8318e5eb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
