Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: fixing development environment ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/34257/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py: Line 96 Line 97 Line 98 Line 99 Line 100 Perhaps move this to stage_setup and add here (late_setup) condition=not _enabled? Line 137: oenginecons.SystemEnv.NFS_CONFIG_ENABLED_LEGACY_IN_POSTINSTALL Line 138: ] = False Line 139: Line 140: if not self.environment[ Line 141: osetupcons.CoreEnv.DEVELOPER_MODE you already check this above for _enabled, not sure you must check twice Line 142: ]: Line 143: rc, stdout, stderr = self.execute( Line 144: ( Line 145: self.command.get('exportfs'), -- To view, visit http://gerrit.ovirt.org/34257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa388eeec683ec2ec4f7e3b3949e296f2078180e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
