Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: fixing development environment ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34257/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py: Line 137: oenginecons.SystemEnv.NFS_CONFIG_ENABLED_LEGACY_IN_POSTINSTALL Line 138: ] = False Line 139: Line 140: if not self.environment[ Line 141: osetupcons.CoreEnv.DEVELOPER_MODE > you already check this above for _enabled, not sure you must check twice It's just a semantic issue: I'm using _enabled for a different purpose, more precisely I'm using it to keep track if engine-setup needs to configure it cause ovirt needs it while for instance I still need to keep NFS ports open also fro external NFS shares. At this point they have the same value, but later on _enables is going to change so I'd prefer to check just what I really need to check without overriding it. Line 142: ]: Line 143: rc, stdout, stderr = self.execute( Line 144: ( Line 145: self.command.get('exportfs'), -- To view, visit http://gerrit.ovirt.org/34257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa388eeec683ec2ec4f7e3b3949e296f2078180e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
