Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: fixing development environment on remote engine ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34259/1/packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_root_ssh.py File packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine_root_ssh.py: Line 277: super(Plugin, self).__init__(context=context) Line 278: Line 279: @plugin.event( Line 280: stage=plugin.Stages.STAGE_SETUP, Line 281: # We want to be the default, so add early > Just setting the env doesn't require anything. It's not a bad idea: in devenv mode it doesn't propose at all the ssh method witch will than fail requiring root access. I tested it on devev where it simply proposes the file method. Line 282: priority=plugin.Stages.PRIORITY_HIGH, Line 283: ) Line 284: def _setup(self): Line 285: self.environment[ -- To view, visit http://gerrit.ovirt.org/34259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b7e75dbf8ffe7a8c251232648685b0d6dbf592b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
