Martin Peřina has posted comments on this change. Change subject: core: handle host architecture in fence flow ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/34646/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java: Line 1435: this.balloonEnabled = enableBalloon; Line 1436: } Line 1437: Line 1438: public ArchitectureType getArchitecture(ServerCpu cpu, VDSGroup cluster) { Line 1439: if (cpu != null && cpu.getArchitecture() != null) { I wouldn't add method like this into entity object, I would prefer this method to be in some helper class. And I would also encapsulate CpuFlagsManagerHandler.FindMaxServerCpuByFlags call inside this method Line 1440: return cpu.getArchitecture(); Line 1441: } Line 1442: // take architecture from the cluster if it is null on the host level Line 1443: return cluster.getArchitecture(); -- To view, visit http://gerrit.ovirt.org/34646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I081361c9f956ea71a715acf0368c79c7130674c7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
