Martin Peřina has posted comments on this change. Change subject: core: handle host architecture in fence flow ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/34646/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsArchitectureHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsArchitectureHelper.java: Line 11: Line 12: public class VdsArchitectureHelper { Line 13: Line 14: static final Logger log = LoggerFactory.getLogger(VdsArchitectureHelper.class); Line 15: public static ArchitectureType getArchitecture(VdsStatic host) { Please provide a comment for the method Line 16: VDSGroup cluster = DbFacade.getInstance().getVdsGroupDao().get(host.getVdsGroupId()); Line 17: VdsDynamic vdsDynamic = DbFacade.getInstance().getVdsDynamicDao().get(host.getId()); Line 18: ServerCpu cpu = CpuFlagsManagerHandler.FindMaxServerCpuByFlags(vdsDynamic.getcpu_flags(), cluster.getcompatibility_version()); Line 19: if (cpu != null && cpu.getArchitecture() != null) { Line 19: if (cpu != null && cpu.getArchitecture() != null) { Line 20: return cpu.getArchitecture(); Line 21: } Line 22: // take architecture from the cluster if it is null on the host level Line 23: log.info("Failed to get architecture type from host information for host '{}'. Using cluster '{}' architecture value instead.", host.getName(), cluster.getName()); Does this message have any meaning for user? Wouldn't debug be better? Line 24: return cluster.getArchitecture(); Line 25: } -- To view, visit http://gerrit.ovirt.org/34646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I081361c9f956ea71a715acf0368c79c7130674c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
