Alon Bar-Lev has posted comments on this change. Change subject: core: remove commons httpclient from provider proxy ......................................................................
Patch Set 25: (2 comments) http://gerrit.ovirt.org/#/c/33458/25/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java: Line 54: public List<? extends Certificate> getCertificateChain() { Line 55: List<? extends Certificate> result = null; Line 56: if (url.getProtocol().equalsIgnoreCase(String.valueOf("https"))) { Line 57: try { Line 58: result = CertificateChain.getSSLPeerCertificates(url); > So should I use null in the 2nd argument? you should open the keystore, if keystore file is missing either create empty keystore or pass null. Line 59: } catch (IOException | GeneralSecurityException e) { Line 60: handleException(e); Line 61: } Line 62: } http://gerrit.ovirt.org/#/c/33458/25/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 205: # Line 206: # PKI artifacts Line 207: # Line 208: SENSITIVE_KEYS="${SENSITIVE_KEYS},ENGINE_PKI_TRUST_STORE_PASSWORD,ENGINE_PKI_ENGINE_STORE_PASSWORD" Line 209: ENGINE_EXTERNAL_PROVIDERS_TRUST_STORE="${ENGINE_VAR}/external_truststore" > Do you mean to have an ENGINE_PKI_ prefix? no... I mean to have: ENGINE_EXTERNAL_PROVIDERS_TRUST_STORE_TYPE=JKS ENGINE_EXTERNAL_PROVIDERS_TRUST_STORE="${ENGINE_VAR}/external_truststore" ENGINE_EXTERNAL_PROVIDERS_TRUST_STORE_PASSWORD=changeit # or whatever it was Line 210: ENGINE_PKI_CA=${ENGINE_PKI}/ca.pem Line 211: ENGINE_PKI_ENGINE_CERT=${ENGINE_PKI}/certs/engine.cer Line 212: ENGINE_PKI_TRUST_STORE_TYPE=JKS Line 213: ENGINE_PKI_TRUST_STORE=${ENGINE_PKI}/.truststore -- To view, visit http://gerrit.ovirt.org/33458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727d34c33f357b93560d4b5a1784b3733b7fa293 Gerrit-PatchSet: 25 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
