Alon Bar-Lev has posted comments on this change. Change subject: core: remove commons httpclient from provider proxy ......................................................................
Patch Set 27: (1 comment) http://gerrit.ovirt.org/#/c/33458/27/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/BaseProviderProxy.java: Line 56: public List<? extends Certificate> getCertificateChain() { Line 57: List<? extends Certificate> result = null; Line 58: if (url.getProtocol().equalsIgnoreCase(String.valueOf("https"))) { Line 59: try { Line 60: KeyStore ks = > I was in a dilemma myself, i will go with your suggestion. no need to encrypt/decrypt passwords within config files, these have ACL for only ovirt user to read. Line 61: EngineLocalConfig.getInstance().getExternalProvidersTrustStore().exists() ? Line 62: KeyStore.getInstance(EngineLocalConfig.getInstance().getExternalProvidersTrustStoreType()) : null; Line 63: if (ks != null) { Line 64: try (FileInputStream ksFileInputStream = -- To view, visit http://gerrit.ovirt.org/33458 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I727d34c33f357b93560d4b5a1784b3733b7fa293 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
