Lior Vernia has posted comments on this change. Change subject: engine: Ensure that all networks on NIC have QoS ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34132/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 248: /** Line 249: * Validates that the feature is supported if any QoS configuration was specified, and that the values associated Line 250: * with it are valid. Line 251: */ Line 252: private void validateNetworkQos() { > A)this method is rather long Split into two different validations. Didn't split into two methods as I'd have to pass the maps around, so kept them in one method but added comments. Line 253: Set<String> someSubInterfacesHaveQos = new HashSet<>(); Line 254: Set<String> notAllSubInterfacesHaveQos = new HashSet<>(); Line 255: Line 256: for (VdsNetworkInterface iface : params.getInterfaces()) { Line 254: Set<String> notAllSubInterfacesHaveQos = new HashSet<>(); Line 255: Line 256: for (VdsNetworkInterface iface : params.getInterfaces()) { Line 257: String networkName = iface.getNetworkName(); Line 258: if (networkName == null) { > this condition can be extracted to variable with some good name explaining Added a comment instead. Line 259: continue; Line 260: } Line 261: Line 262: Network network = existingClusterNetworks.get(networkName); -- To view, visit http://gerrit.ovirt.org/34132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59bf1bd6fcd26c3229cf0068d06e643b1abe1003 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
