Lior Vernia has posted comments on this change. Change subject: engine: Ensure that all networks on NIC have QoS ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/34132/10//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-11-06 15:42:47 +0200 Line 6: Line 7: engine: Ensure that all networks on NIC have QoS Line 8: Line 9: Becuase of various damaging edge cases where some networks have QoS > s/Becuase/Because Done Line 10: configured on top of one logical interface while others don't, this Line 11: blocks a setup networks operation if only some of the networks on the Line 12: interface have it configured. Line 13: http://gerrit.ovirt.org/#/c/34132/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java: Line 260: } Line 261: Line 262: Network network = existingClusterNetworks.get(networkName); Line 263: String baseIfaceName = NetworkUtils.stripVlan(iface); Line 264: if (NetworkUtils.qosConfiguredOnInterface(iface, network)) { > As I understood from you, you need this patch to make sure there is no mix Done, modified documentation. Line 265: someSubInterfacesHaveQos.add(baseIfaceName); Line 266: if (iface.isQosOverridden()) { Line 267: if (!hostNetworkQosSupported) { Line 268: addViolation(VdcBllMessages.ACTION_TYPE_FAILED_HOST_NETWORK_QOS_NOT_SUPPORTED, networkName); -- To view, visit http://gerrit.ovirt.org/34132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59bf1bd6fcd26c3229cf0068d06e643b1abe1003 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
