Oved Ourfali has posted comments on this change. Change subject: Add domain url to provisioned vds and set name as unchangeable ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/35214/4//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-11-17 11:25:57 -0500 Line 6: Line 7: Add domain url to provisioned vds and set name as unchangeable Line 8: Line 9: Currently the picked vds name for provisioned host is the deafult foreman's you mean "discovered" host? Line 10: name which set to the host during first boot (e.g mac12345678). The full Line 11: hostname which set to the host after provision includes also domain url. Line 12: Line 13: In this patch we create the initial vds name record with the hostgroup domain http://gerrit.ovirt.org/#/c/35214/4/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java: Line 76: ExternalDiscoveredHost dhost = (ExternalDiscoveredHost) getExternalDiscoveredHosts().getSelectedItem(); Line 77: ExternalHostGroup dhg = (ExternalHostGroup) getExternalHostGroups().getSelectedItem(); Line 78: VDS vds = new VDS(); Line 79: if (dhost != null && dhg != null) { Line 80: vds.setVdsName(dhost.getName() + "." + dhg.getDomainName()); //$NON-NLS-1$ so the name will be mac.domain? Is it changable? Line 81: vds.setHostName(dhost.getIp()); Line 82: } Line 83: updateModelFromVds(vds, null, false, null); Line 84: } -- To view, visit http://gerrit.ovirt.org/35214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74e17d69423e1c02028f596ecafb13a21ab3e3ca Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
