Daniel Erez has posted comments on this change. Change subject: ui: fixing display of host fqdn in addHost form ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/35214/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NewHostModel.java: Line 145: } Line 146: }; Line 147: AsyncDataProvider.getInstance().getExternalProviderComputeResourceList(getComputeResourceQuery, provider); Line 148: Line 149: AsyncQuery getHostsQuery = new AsyncQuery(); looks like a race... should be solved by canonicalize the querys. Line 150: getHostsQuery.asyncCallback = new INewAsyncCallback() { Line 151: @Override Line 152: public void onSuccess(Object model, Object result) { Line 153: ArrayList<VDS> hosts = (ArrayList<VDS>) result; -- To view, visit http://gerrit.ovirt.org/35214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74e17d69423e1c02028f596ecafb13a21ab3e3ca Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
