Moti Asayag has posted comments on this change. Change subject: core: EAR use jboss-deployment-structure.xml instead manifest ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/29440/9/ear/src/main/application/META-INF/jboss-deployment-structure.xml File ear/src/main/application/META-INF/jboss-deployment-structure.xml: can we maintain this file sorted ? the ordered content of modules should be: <module name="asm.asm"/> <module name="com.woorea.openstack.sdk" export="true" services="true"/> <module name="javax.annotation.api"/> <module name="javax.enterprise.api"/> <module name="javax.inject.api"/> <module name="javax.interceptor.api"/> <module name="javax.validation.api"/> <module name="org.apache.commons.beanutils" export="true"/> <module name="org.apache.commons.codec" export="true"/> <module name="org.apache.commons.collections" export="true"/> <module name="org.apache.commons.httpclient" export="true"/> <module name="org.apache.commons.lang" export="true"/> <module name="org.apache.log4j" export="true"/> <module name="org.apache.xmlgraphics.fop" export="true"/> <module name="org.apache.xmlrpc" export="true"/> <module name="org.codehaus.jackson.jackson-core-asl" export="true"/> <module name="org.codehaus.jackson.jackson-mapper-asl" export="true"/> <module name="org.dom4j" export="true"/> <module name="org.hibernate.validator" export="true"/> <module name="org.infinispan" export="true"/> <module name="org.jboss.resteasy.resteasy-jaxrs" export="true"/> <module name="org.ovirt.engine.api.ovirt-engine-extensions-api" export="true"/> <module name="org.ovirt.engine.core.aaa" export="true" meta-inf="import"/> <module name="org.ovirt.engine.core.common" export="true" meta-inf="import"/> <module name="org.ovirt.engine.core.compat" export="true"/> <module name="org.ovirt.engine.core.dal" export="true" meta-inf="import"/> <module name="org.ovirt.engine.core.extensions-manager" export="true"/> <module name="org.ovirt.engine.core.searchbackend" export="true"/> <module name="org.ovirt.engine.core.utils" export="true" meta-inf="import"/> <module name="org.ovirt.engine.core.uutils" export="true"/> <module name="org.ovirt.engine.extensions.builtin" export="true"/> <module name="org.ovirt.otopi" export="true"/> <module name="org.ovirt.ovirt-host-deploy" export="true"/> <module name="org.ovirt.vdsm-jsonrpc-java" export="true"/> <module name="org.quartz" export="true"/> <module name="org.springframework" export="true"/> <module name="org.yaml.snakeyaml" export="true"/> Line 1: <jboss-deployment-structure> Line 2: <deployment> Line 3: <dependencies> Line 4: <module name="javax.annotation.api"/> -- To view, visit http://gerrit.ovirt.org/29440 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I157edc033927ea3bb1a32448498e03e289bf55c4 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
