Roy Golan has posted comments on this change.

Change subject: core: EAR use jboss-deployment-structure.xml instead manifest
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.ovirt.org/#/c/29440/9/ear/src/main/application/META-INF/jboss-deployment-structure.xml
File ear/src/main/application/META-INF/jboss-deployment-structure.xml:

> can we maintain this file sorted ?
certainly. although I need to make sure there isn't any meaning to the order 
they appear.
Line 1: <jboss-deployment-structure>
Line 2:   <deployment>
Line 3:       <dependencies>
Line 4:           <module name="javax.annotation.api"/>


-- 
To view, visit http://gerrit.ovirt.org/29440
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I157edc033927ea3bb1a32448498e03e289bf55c4
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to