Juan Hernandez has posted comments on this change. Change subject: restapi: adjust api to new graphics representation ......................................................................
Patch Set 4: Code-Review+1 (2 comments) Looks good, only a couple of minor comments inside. http://gerrit.ovirt.org/#/c/35281/4/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/DisplayType.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/DisplayType.java: Line 41: return GraphicsType.VNC; Line 42: default: Line 43: return null; Line 44: } Line 45: } If possible move this method to the DisplayMapper class. http://gerrit.ovirt.org/#/c/35281/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/DisplayHelper.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/DisplayHelper.java: Line 46: } Line 47: } Line 48: Line 49: return graphicsTypes; Line 50: } Consider making this method static (is the only one that isn't static) and then remove the getInstance method. Line 51: Line 52: /** Line 53: * Set data about graphics from (REST) Template to parameters. Line 54: * -- To view, visit http://gerrit.ovirt.org/35281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibed6bbbce8a36dff82a0903c3478cfb656589fb4 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
