Juan Hernandez has posted comments on this change.

Change subject: restapi: adjust api to new graphics representation
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/35281/4/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/DisplayHelper.java
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/DisplayHelper.java:

Line 46:             }
Line 47:         }
Line 48: 
Line 49:         return graphicsTypes;
Line 50:     }
> Not sure about this - if I do it, I won't be able to use getEntity(...), ri
Ah, true, good that you mention it. You shouldn't extend "ResourceHelper" at 
all, it has been removed some time ago. You need to rebase and rebuild.

If you need to use any resource method like "getEntity" then pass the resource 
as the first parameter:

  public static ... whatever(BackendResource resource, ...) {
    resource.getEntity(...);
  }
Line 51: 
Line 52:     /**
Line 53:      * Set data about graphics from (REST) Template to parameters.
Line 54:      *


-- 
To view, visit http://gerrit.ovirt.org/35281
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibed6bbbce8a36dff82a0903c3478cfb656589fb4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to