Oved Ourfali has uploaded a new change for review. Change subject: core: fix AddDisk permission check ......................................................................
core: fix AddDisk permission check When someone adds a floating from the webadmin UI, the vm id is EMPTY_GUID. However, in the permissions check, we check for null. This patch checks for null, and if the vm id isn't null, it checks if it is an empty guid. Change-Id: Ibf0220700a9675d17f553df2b96f2e1da3b621b1 Signed-off-by: Oved Ourfali <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/40/7140/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java index 6c24c40..4b3b4c8 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java @@ -249,7 +249,7 @@ @Override public List<PermissionSubject> getPermissionCheckSubjects() { List<PermissionSubject> listPermissionSubjects; - if (getParameters().getVmId() == null) { + if (getParameters().getVmId() == null || Guid.Empty.equals(getParameters().getVmId())) { listPermissionSubjects = new ArrayList<PermissionSubject>(); } else { listPermissionSubjects = super.getPermissionCheckSubjects(); -- To view, visit http://gerrit.ovirt.org/7140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf0220700a9675d17f553df2b96f2e1da3b621b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
