Sharad Mishra has posted comments on this change.
Change subject: core: fix AddDisk permission check
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 248:
Line 249: @Override
Line 250: public List<PermissionSubject> getPermissionCheckSubjects() {
Line 251: List<PermissionSubject> listPermissionSubjects;
Line 252: if (getParameters().getVmId() == null ||
Guid.Empty.equals(getParameters().getVmId())) {
What threw me off was the fact that if getParameters().getVMId() is null, then
the first check above will be true but the one in NGuid.equals() is false. But
since it is an "||" operation it does not matter. So, I guess we are okay here.
Line 253: listPermissionSubjects = new
ArrayList<PermissionSubject>();
Line 254: } else {
Line 255: listPermissionSubjects =
super.getPermissionCheckSubjects();
Line 256: }
--
To view, visit http://gerrit.ovirt.org/7140
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0220700a9675d17f553df2b96f2e1da3b621b1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
