Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Create vdsm user and kvm group (#847833)
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 32: /usr/bin/getent passwd %{engine_user} >/dev/null || /usr/sbin/useradd
-c "%{user_description}" -u %{engine_uid} -g %{engine_group} -M -d
%{engine_state} %{engine_user}
Line 33:
Line 34: # The name of the VDSM user and group:
Line 35: %global vdsm_user vdsm
Line 36: %global vdsm_group kvm
Why not put this above by the engine_user settings, this way we have all in one
place.
Also put the uid guid there...
And maybe the macro can be create_user and pass parameters...
Line 37:
Line 38: # Macro to create the VDSM user:
Line 39: %global create_vdsm_user \
Line 40: /usr/bin/getent group %{vdsm_group} >/dev/null || /usr/sbin/groupadd
-r -g 36 %{vdsm_group}; \
--
To view, visit http://gerrit.ovirt.org/7247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cca5a00df645c375e2c5a0f30e4bb47853cc22b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
