Juan Hernandez has posted comments on this change. Change subject: packaging: Create vdsm user and kvm group (#847833) ......................................................................
Patch Set 3: Looks good to me, approved (1 inline comment) .................................................... File packaging/fedora/spec/ovirt-engine.spec.in Line 31: %global vdsm_description Node Virtualization Manager Line 32: %global vdsm_user vdsm Line 33: %global vdsm_group kvm Line 34: %global vdsm_uid 36 Line 35: %global vdsm_gid 36 Alon, the "vdsm_description" is required. I can't find other (easy) way to include spaces in a parameter to a RPM macro. The others are not required, but as you say it is not a blocker I interpret this comment as a +1. Line 36: Line 37: # Macro to create an user: Line 38: # Line 39: # %1 user name -- To view, visit http://gerrit.ovirt.org/7247 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cca5a00df645c375e2c5a0f30e4bb47853cc22b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
