Yair Zaslavsky has posted comments on this change. Change subject: engine: Permission given to a group doesn't apply to its member because of wrong view creation (#847333) ......................................................................
Patch Set 1: (2 inline comments) Looks good to me. Minor comments on commit message, please address them. I would like Allon and/or Oved to take a look as well, before giving you +2. .................................................... Commit Message Line 10: The error was that user of a group doesn't get the same permissions that the group does have. Line 11: The user gets its own specific permissions only. Line 12: Line 13: This happens because the view user_permissions_permissions_view using user_flat_groups in a wrong way, Line 14: the view supposes to make a table of permissions connected to user_id as permission_view, but this view supposes = is suppposed to. Line 15: connects also subusers of groups to their group's permissions. Line 16: Line 17: But it doesn't do that right, that's the reason why GetPermissionsByAdElementIdQuery returns only permissions Line 18: on specific user without including its group permissions. Line 17: But it doesn't do that right, that's the reason why GetPermissionsByAdElementIdQuery returns only permissions Line 18: on specific user without including its group permissions. Line 19: Line 20: The real bug is the wrong output of - user_permission_permissions_view. If that view output is correct Line 21: and somewhere else we use it, the function GetPermissionsByAdElementIdQuery implemented wrong. Not sure what you tried to say in this line :) Please rephrase. Line 22: Line 23: Change-Id: Ice68f05528f5952848f47c029f2216d7ddd7899e -- To view, visit http://gerrit.ovirt.org/7262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice68f05528f5952848f47c029f2216d7ddd7899e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
