Allon Mureinik has posted comments on this change. Change subject: engine: Permission given to a group doesn't apply to its member because of wrong view creation (#847333) ......................................................................
Patch Set 1: (3 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2012-08-16 16:07:08 +0300 Line 4: Commit: Yaniv Bronhaim <[email protected]> Line 5: CommitDate: 2012-08-16 16:11:48 +0300 Line 6: Line 7: engine: Permission given to a group doesn't apply to its member because of wrong view creation (#847333) please try to keep the subject under 50 chars. Line 8: Line 9: This patch fixing creation of user_permission_permissions_view. Line 10: The error was that user of a group doesn't get the same permissions that the group does have. Line 11: The user gets its own specific permissions only. Line 5: CommitDate: 2012-08-16 16:11:48 +0300 Line 6: Line 7: engine: Permission given to a group doesn't apply to its member because of wrong view creation (#847333) Line 8: Line 9: This patch fixing creation of user_permission_permissions_view. s/fixing/fixes the/ Line 10: The error was that user of a group doesn't get the same permissions that the group does have. Line 11: The user gets its own specific permissions only. Line 12: Line 13: This happens because the view user_permissions_permissions_view using user_flat_groups in a wrong way, Line 9: This patch fixing creation of user_permission_permissions_view. Line 10: The error was that user of a group doesn't get the same permissions that the group does have. Line 11: The user gets its own specific permissions only. Line 12: Line 13: This happens because the view user_permissions_permissions_view using user_flat_groups in a wrong way, s/using/uses/ Line 14: the view supposes to make a table of permissions connected to user_id as permission_view, but this view Line 15: connects also subusers of groups to their group's permissions. Line 16: Line 17: But it doesn't do that right, that's the reason why GetPermissionsByAdElementIdQuery returns only permissions -- To view, visit http://gerrit.ovirt.org/7262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ice68f05528f5952848f47c029f2216d7ddd7899e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
