Asaf Shakarchi has uploaded a new change for review. Change subject: engine: StoragePool storage_pool_format_type is lost in update (#845310) ......................................................................
engine: StoragePool storage_pool_format_type is lost in update (#845310) https://bugzilla.redhat.com/845310 StoragePool's storage_pool_format_type property is not set in params entity (as it's not visible in UI) so the value is lost during storage pool update, This patch copies the property value from the old entity. Change-Id: I4e19bc2102e40c818b8953a08d1203c3a9b042b0 Signed-off-by: Asaf Shakarchi <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/7265/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java index 62bd917..0343665 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java @@ -59,6 +59,9 @@ ); } } + + updateNewStoragePoolEntity(getStoragePool(), _oldStoragePool); + getStoragePoolDAO().updatePartial(getStoragePool()); updateStoragePoolFormatType(); @@ -225,4 +228,14 @@ protected StorageDomainStaticDAO getStorageDomainStaticDAO() { return DbFacade.getInstance().getStorageDomainStaticDAO(); } + + /** + * Copy properties from old entity which assumed not to be available in the param object. + * + * @param oldStoragePool + * @param newStoragePool + */ + private void updateNewStoragePoolEntity(storage_pool newStoragePool, storage_pool oldStoragePool) { + newStoragePool.setStoragePoolFormatType(oldStoragePool.getStoragePoolFormatType()); + } } -- To view, visit http://gerrit.ovirt.org/7265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4e19bc2102e40c818b8953a08d1203c3a9b042b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
