Allon Mureinik has posted comments on this change.
Change subject: engine: StoragePool storage_pool_format_type is lost in update
(#845310)
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
minor issues, see inline.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
Line 59: );
Line 60: }
Line 61: }
Line 62:
Line 63: updateNewStoragePoolEntity(getStoragePool(), _oldStoragePool);
the name isn't intuitive, IMHO.
perhaps copyUnchangedStoragePoolProperties(), or something down those lines?
Line 64:
Line 65: getStoragePoolDAO().updatePartial(getStoragePool());
Line 66:
Line 67: updateStoragePoolFormatType();
Line 234: *
Line 235: * @param oldStoragePool
Line 236: * @param newStoragePool
Line 237: */
Line 238: private void updateNewStoragePoolEntity(storage_pool
newStoragePool, storage_pool oldStoragePool) {
I believe this could be static.
Line 239:
newStoragePool.setStoragePoolFormatType(oldStoragePool.getStoragePoolFormatType());
Line 240: }
--
To view, visit http://gerrit.ovirt.org/7265
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e19bc2102e40c818b8953a08d1203c3a9b042b0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
