Lior Vernia has posted comments on this change. Change subject: core: Remove code duplication in VdsNetworkInterface.toString() ......................................................................
Patch Set 2: Changed the implementation to maintain a Map which is then serialized to a string - this should help maintain form. As for verbosity - even though this goes into logs, if there's data we know isn't relevant for some types of interface (e.g. it's supposed to always be null), then there's value in keeping it cleaner. The engine log is something human beings look at, quite a lot. -- To view, visit http://gerrit.ovirt.org/36215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94bbf7113e848f6ca8ae4a38e46303050d653135 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
