Lior Vernia has posted comments on this change. Change subject: core: Remove code duplication in VdsNetworkInterface.toString() ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36215/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VdsNetworkInterface.java: Line 453: StringBuilder builder = new StringBuilder(); Line 454: builder.append(getName()).append(" {"); Line 455: Line 456: Iterator<Entry<String, Object>> attributes = constructSerializationAttributes().entrySet().iterator(); Line 457: builder.append(attributes.next()); > I have to write here, that this will fail if attributes are empty, but even Yeah, I thought about it when I wrote this and decided it wasn't necessary. But then again, there's no reason why not make this more robust. Added proper checks. Line 458: while (attributes.hasNext()) { Line 459: builder.append(", ").append(attributes.next()); Line 460: } Line 461: -- To view, visit http://gerrit.ovirt.org/36215 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94bbf7113e848f6ca8ae4a38e46303050d653135 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
