Allon Mureinik has posted comments on this change.

Change subject: core: AddStorageDomainCommand CDA addition
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/36393/1/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
File 
backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties:

Line 556: EN_EVENT_DOWN_SUBJECT_TEXT=Issue Solved Notification.
Line 557: EN_ALREADY_SUBSCRIBED=User is already subscribed to this event with 
the same Notification method.
Line 558: EN_NOT_SUBSCRIBED=Cannot ${action} ${type}.User is not subscribed to 
this event with the given Notification method.
Line 559: ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL=Cannot ${action} 
${type}. Storage Domain type not specified.
Line 560: 
ACTION_TYPE_FAILED_EXPORT_DOMAIN_CANNOT_BE_APPLIED_ON_BLOCK_STORAGE=Cannot 
${action} ${type}. Export domain cannot be applied on block storage.
But you fail the CDA on local fs too.

"Export domain can only be created on shared file domains"
Line 561: ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL=Cannot ${action} 
${type}. Storage Domain format ${storageFormat} is illegal.
Line 562: ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST=Cannot 
${action} ${type}. Storage format ${storageFormat} is not supported on the 
selected host version.
Line 563: ERROR_CANNOT_EXTEND_NON_DATA_DOMAIN=Cannot extend Storage Domain. 
Extend operation is supported only on Data Storage Domain.
Line 564: ERROR_CANNOT_EXTEND_CONNECTION_FAILED=Cannot extend Storage Domain. 
Storage device ${lun} is unreachable on ${hostName}.


-- 
To view, visit http://gerrit.ovirt.org/36393
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80f68c866e583152b80780554f5529eb720e0759
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to