Vered Volansky has posted comments on this change. Change subject: core: Prevent Export domains on block storage ......................................................................
Patch Set 3: Code-Review-1 (1 comment) Looks good, but check if the unit test fails for real, and even i it doesn't this should have a unit test on its own. http://gerrit.ovirt.org/#/c/36393/3//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-12-24 15:50:53 -0500 Line 6: Line 7: core: Prevent Export domains on block storage Line 8: Line 9: Block domains does not support export type. Thus a validation was added s/does/do Line 10: in AddStorageDomainCommand CDA. Line 11: Line 12: Change-Id: I80f68c866e583152b80780554f5529eb720e0759 Line 13: Bug-Url: https://bugzilla.redhat.com/1065989 -- To view, visit http://gerrit.ovirt.org/36393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f68c866e583152b80780554f5529eb720e0759 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
