Liron Aravot has posted comments on this change. Change subject: core: Prevent Export domains on block storage ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/36393/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java: Line 156: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_NAME_ALREADY_EXIST); Line 157: } Line 158: if (getStorageDomain().getStorageDomainType() == StorageDomainType.ISO Line 159: && !getStorageDomain().getStorageType().isFileDomain()) { Line 160: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL); in further patch this message can be fixed as well Line 161: } Line 162: if (getStorageDomain().getStorageDomainType() == StorageDomainType.ImportExport Line 163: && (getStorageDomain().getStorageType() == StorageType.LOCALFS || getStorageDomain().getStorageType().isBlockDomain())) { Line 164: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_EXPORT_DOMAIN_CAN_BE_APPLIED_ONLY_ON_SHARED_FILE_DOMAINS); http://gerrit.ovirt.org/#/c/36393/4/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 556: EN_EVENT_DOWN_SUBJECT_TEXT=Issue Solved Notification. Line 557: EN_ALREADY_SUBSCRIBED=User is already subscribed to this event with the same Notification method. Line 558: EN_NOT_SUBSCRIBED=Cannot ${action} ${type}.User is not subscribed to this event with the given Notification method. Line 559: ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_ILLEGAL=Cannot ${action} ${type}. Storage Domain type not specified. Line 560: ACTION_TYPE_FAILED_EXPORT_DOMAIN_CAN_BE_APPLIED_ONLY_ON_SHARED_FILE_DOMAINS=Cannot ${action} ${type}. Export domain can only be created on shared file domains. Please make the message more generic..so we can use it for other cases as well (for example, the ISO domain check before the one you fixed). please also change the name to be more generic. Cannot ${action} ${type}. ${DomainType} domain can only be created on ${StorageTypes} Domain domains. Line 561: ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL=Cannot ${action} ${type}. Storage Domain format ${storageFormat} is illegal. Line 562: ACTION_TYPE_FAILED_STORAGE_DOMAIN_FORMAT_ILLEGAL_HOST=Cannot ${action} ${type}. Storage format ${storageFormat} is not supported on the selected host version. Line 563: ERROR_CANNOT_EXTEND_NON_DATA_DOMAIN=Cannot extend Storage Domain. Extend operation is supported only on Data Storage Domain. Line 564: ERROR_CANNOT_EXTEND_CONNECTION_FAILED=Cannot extend Storage Domain. Storage device ${lun} is unreachable on ${hostName}. -- To view, visit http://gerrit.ovirt.org/36393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80f68c866e583152b80780554f5529eb720e0759 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
