Yedidyah Bar David has posted comments on this change. Change subject: utils: RedirectServlet: replace localhost to engine host ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/35885/4/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java: Line 44: Matcher m = urlPattern.matcher(url); Line 45: if (m.matches()) { Line 46: String host = m.group("host"); Line 47: if (host != null) { Line 48: if (host.equals("localhost") || host.startsWith("127.") || host.equals("::1")) { Maybe make this test user-configurable too? E.g. add somewhere a conf LOCALHOST_RE and check if host matches it, or something like that? Line 49: url = String.format( Line 50: "%s%s%s", Line 51: m.group("prefix") != null ? m.group("prefix") : "", Line 52: LOCALHOST_PLACEHOLDER, -- To view, visit http://gerrit.ovirt.org/35885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I155489de230124339be4f2493686c83ebaee3a68 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
