Yedidyah Bar David has posted comments on this change. Change subject: utils: RedirectServlet: replace localhost to engine host ......................................................................
Patch Set 6: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/35885/6/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/servlet/RedirectServlet.java: Line 42: private static final Set localHostNames = new HashSet(Arrays.asList( Line 43: "localhost", Line 44: "localhost.localdomain", Line 45: "localhost6", Line 46: "localhost6.localdomain" In rhel/fedora I have: 127.0.0.1 localhost localhost.localdomain localhost4 localhost4.localdomain4 ::1 localhost localhost.localdomain localhost6 localhost6.localdomain6 In debian I have: 127.0.0.1 localhost ::1 localhost ip6-localhost ip6-loopback Feel free to pick what you like. I never saw "localhost6.localdomain", but do find it in google (mostly related to some vmware fusion dns server?). Line 47: )); Line 48: Line 49: private String targetUrl; Line 50: private String url404; -- To view, visit http://gerrit.ovirt.org/35885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I155489de230124339be4f2493686c83ebaee3a68 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
