Barak Azulay has posted comments on this change.
Change subject: pki: use PKCS#12 format to store keys
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 644: logging.error("PKI: cannot symlink '%s'->'%s'" %
(basedefs.FILE_PRIVATE_SSH_KEY, basedefs.FILE_ENGINE_PRIVATE_KEY) )
Line 645: raise
Line 646:
Line 647: def rollback(self):
Line 648: if os.path.exists(self.JKSKEYSTORE):
It looks to me like there is a chance that the rollback can be called when the
CA is not fully commited but JKSKEYSTORE does not exist.
In this case the rollback will leave the system unusable.
Line 649: for f in (basedefs.FILE_ENGINE_KEYSTORE,
basedefs.FILE_ENGINE_PRIVATE_KEY):
Line 650: try:
Line 651: os.remove(f)
Line 652: except OSError:
--
To view, visit http://gerrit.ovirt.org/6883
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2abda5778477faff09798a43cf3dc96435efb272
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
