Barak Azulay has posted comments on this change.
Change subject: pki: use PKCS#12 format to store keys
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 573: class CA():
Line 574:
Line 575: JKSKEYSTORE = "/etc/pki/ovirt-engine/.keystore"
Line 576: rollback_keystore = False
Line 577: rollback_key = False
The above rollback_* variables are not in use
Line 578:
Line 579: def prepare(self):
Line 580: if os.path.exists(self.JKSKEYSTORE):
Line 581: logging.debug("PKI: convert JKS to PKCS#12")
Line 620: raise
Line 621:
Line 622: utils.updateVDCOption("keystoreUrl",
basedefs.FILE_ENGINE_KEYSTORE, (), "text")
Line 623: utils.updateVDCOption("TruststoreUrl",
basedefs.FILE_TRUSTSTORE, (), "text")
Line 624: utils.updateVDCOption("CertAlias", "1", (), "text")
Shouldn't the above 3 commands be a part of the commit ?
Line 625:
Line 626: def commit(self):
Line 627: if os.path.exists(self.JKSKEYSTORE):
Line 628: logging.debug("PKI: removing JKS keystore")
--
To view, visit http://gerrit.ovirt.org/6883
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2abda5778477faff09798a43cf3dc96435efb272
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
