Liron Aravot has posted comments on this change. Change subject: core: Limitation addition for downgrading DC's compatible version. ......................................................................
Patch Set 20: (2 comments) http://gerrit.ovirt.org/#/c/35790/20/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java: Line 279: sdISCI.setStorageType(StorageType.ISCSI); Line 280: Line 281: StorageDomain sdNFS = new StorageDomain(); Line 282: sdNFS.setStorageFormat(StorageFormatType.V3); Line 283: sdNFS.setStorageType(StorageType.NFS); I'd move this to a method (create storage domain) that accepts the three arguments and replace all those creations with a call to it. Line 284: Line 285: setAttachedDomains(sdISCI, sdNFS); Line 286: Line 287: List<StorageType> storageTypes = new ArrayList<>(); Line 283: sdNFS.setStorageType(StorageType.NFS); Line 284: Line 285: setAttachedDomains(sdISCI, sdNFS); Line 286: Line 287: List<StorageType> storageTypes = new ArrayList<>(); You can use Arrays.asList(....) Line 288: storageTypes.add(sdISCI.getStorageType()); Line 289: storageTypes.add(sdNFS.getStorageType()); Line 290: Line 291: doReturn(storageTypes).when(spDao).getStorageTypesInPool(any(Guid.class)); -- To view, visit http://gerrit.ovirt.org/35790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib97488c705a32fe73b390ef226b1ad19a3784b76 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
