Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: expose total memory in env ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37437/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py: Line 52: ) Line 53: Line 54: def __init__(self, context): Line 55: super(Plugin, self).__init__(context=context) Line 56: self.environment[osetupcons.ConfigEnv.TOTAL_MEMORY_MB] = 0 I'd prefer to use self.environment.setdefault( osetupcons.ConfigEnv.TOTAL_MEMORY_MB, 0 ) as a code convention also assuming that we are than going to read the actual value. Line 57: Line 58: def _check_requirements(self): Line 59: satisfied = False Line 60: if self.environment[ -- To view, visit http://gerrit.ovirt.org/37437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia25b24fb263390c9f6ae50708e2c3791d2c7a987 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
