Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: expose total memory in env ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37437/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/memcheck.py: Line 52: ) Line 53: Line 54: def __init__(self, context): Line 55: super(Plugin, self).__init__(context=context) Line 56: self.environment[osetupcons.ConfigEnv.TOTAL_MEMORY_MB] = 0 > I think we shouldn't mess with total memory value with the answer file. We On my opinion we should try as possible to maintain a consistent behavior on all the environment variables regardless of the specific case and meaning. So, if a variable is in the environment, it's value should be overridable from external maybe just for testing purposes. Of course it doesn't mean that we always have to save its value in the answer file, in this case for instance it would be dangerous but on my opinion we still need to honor its value if for any reason we'll find. Line 57: Line 58: def _check_requirements(self): Line 59: satisfied = False Line 60: if self.environment[ -- To view, visit http://gerrit.ovirt.org/37437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia25b24fb263390c9f6ae50708e2c3791d2c7a987 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
