Martin Mucha has posted comments on this change. Change subject: restapi: rest part for UnmanagedNetworks. ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/37878/1/backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd: Line 3789: <xs:sequence> Line 3790: <xs:element ref="unmanaged_network" minOccurs="0" maxOccurs="unbounded"> Line 3791: <xs:annotation> Line 3792: <xs:appinfo> Line 3793: <jaxb:property name="unmanagedNetworks"/> > Although it isn't really important, the name used in these annotations usua Done Line 3794: </xs:appinfo> Line 3795: </xs:annotation> Line 3796: </xs:element> Line 3797: </xs:sequence> http://gerrit.ovirt.org/#/c/37878/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUnmanagedNetworkResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUnmanagedNetworkResource.java: Line 1: package org.ovirt.engine.api.restapi.resource; Line 2: Line 3: import org.ovirt.engine.api.model.Host; Line 4: import org.ovirt.engine.api.resource.UnmanagedNetworkResource; Line 5: import org.ovirt.engine.core.common.businessentities.UnmanagedNetwork; > When there is class name conflict please try to import the RESTAPI type (or Done Line 6: import org.ovirt.engine.core.common.queries.UnmanagedNetworkParameters; Line 7: import org.ovirt.engine.core.common.queries.VdcQueryType; Line 8: import org.ovirt.engine.core.compat.Guid; Line 9: http://gerrit.ovirt.org/#/c/37878/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUnmanagedNetworksResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendUnmanagedNetworksResource.java: Line 11: import org.ovirt.engine.api.resource.UnmanagedNetworksResource; Line 12: import org.ovirt.engine.api.restapi.utils.HexUtils; Line 13: import org.ovirt.engine.core.common.action.HostSetupNetworksParameters; Line 14: import org.ovirt.engine.core.common.action.VdcActionType; Line 15: import org.ovirt.engine.core.common.businessentities.UnmanagedNetwork; > Consider importing the RESTAPI type and using the fully qualified name of t Done Line 16: import org.ovirt.engine.core.common.queries.IdQueryParameters; Line 17: import org.ovirt.engine.core.common.queries.VdcQueryType; Line 18: import org.ovirt.engine.core.compat.Guid; Line 19: http://gerrit.ovirt.org/#/c/37878/1/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UnmanagedNetworkMapper.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UnmanagedNetworkMapper.java: Line 14: Line 15: org.ovirt.engine.core.common.businessentities.UnmanagedNetwork entity = template == null ? new org.ovirt.engine.core.common.businessentities.UnmanagedNetwork() : template; Line 16: Line 17: if (model.isSetId()) { Line 18: entity.setId(HexUtils.hex2string(model.getName())); > Here you are checking for the presence of the id and then using the name. S Done Line 19: } Line 20: Line 21: if (model.isSetName()) { Line 22: entity.setNetworkName(model.getName()); -- To view, visit http://gerrit.ovirt.org/37878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icfd30d340e7ec9e1da0f752a188dc4ba80211043 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
