Martin Mucha has posted comments on this change.
Change subject: restapi: rest part for UnmanagedNetworks.
......................................................................
Patch Set 3:
so yes. If you manage to get method annotated by @SingleEntityResource or get()
method on {singular}Resource to fail, then check for existence in
org.ovirt.engine.api.restapi.resource.AbstractBackendCollectionResource#remove
will "skipped" only with notice in log and code execution will proceed with
removal.
Comments:
• this is somewhat quirky, but I cannot see how this can be used to do anything
bad, except for higher probability of bad response to the user. I think, that
design of method
org.ovirt.engine.api.restapi.resource.AbstractBackendCollectionResource#getEntity
is problematic; I'd expect 500 or 404 in case of problems, definitely not 200:
"There was some reflection mishap or security exception fired, but dude, carry
on, no problem." Maybe too benevolent.
• when querying for method annotated with @SingleEntityResource we did not use
signature and let fail invocation with wrong arguments.
• get() method revealed using reflection can be easily dictated by interface
instead of team "know-how".
Please let me know if you want have any of these fixed.
--
To view, visit http://gerrit.ovirt.org/37878
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd30d340e7ec9e1da0f752a188dc4ba80211043
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Martin Mucha <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
