Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: node id: consider bonding MAC addresses as well
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1398: // <HW UUID>_<lowest MAC>
Line 1399: @Reloadable
Line 1400: @TypeConverterAttribute(String.class)
Line 1401: @DefaultValueAttribute(
Line 1402: "dmidecode | awk ' /UUID/{ print $2; } ' | tr '\n' '_'
&& " +
I thought that if value is missing from database the default is used... Why
bother storing defaults within database?
I just verified that this does not exist in database.
Line 1403: "(" +
Line 1404: "cat /sys/class/net/*/address;" +
Line 1405: "[ -d /proc/net/bonding ] && " +
Line 1406: "find /proc/net/bonding -type f -exec cat '{}'
\\; | " +
--
To view, visit http://gerrit.ovirt.org/7582
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I31ce43972fad77c716aff915d29d6589ba205280
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Kaul <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
