Alon Bar-Lev has posted comments on this change.

Change subject: bootstrap: node id: consider bonding MAC addresses as well
......................................................................


Patch Set 1:

Well, the following will be better:

 "dmidecode | awk ' /UUID/{ print $2; } ' | tr '\n' '_' && " +
 "for f in /sys/class/net/*; do " +
     "ethtool -P \"$(basename \"${f}\")\" 2> /dev/null | " +
     "sed 's/.*: //'; " +
 "done | " +
 "sed -e '/00:00:00:00/d' -e '/^$/d' | " +
 "sort -u | head -n 1"

As it will also use real hardware mac and not alternate mac. However, RHEL 
ethtool does not support -P.

--
To view, visit http://gerrit.ovirt.org/7582
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I31ce43972fad77c716aff915d29d6589ba205280
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Kaul <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to