Alon Bar-Lev has posted comments on this change. Change subject: packaging: Find and check JVM during setup (#834436) ......................................................................
Patch Set 2: Hi, I don't think that doing this in setup is a good idea, if java is updated it should effect system. Also, please note that in modern operating systems, in which alternatives is really an interface you can query the interface for specific jvm, for example at Gentoo: JAVA_HOME="$(java-config --jre-home icedtea-7)" The above should be done at runtime when java application is starting. Also note that the output of the version string is something that is not constant, at my side: $ java -version java version "1.7.0_05" OpenJDK Runtime Environment (IcedTea7 2.2.1) (Gentoo build 1.7.0_05-b21) OpenJDK 64-Bit Server VM (build 23.0-b21, mixed mode) I urge you again to consider testing the compliant from within the JRE by executing a simple java program to check version, vendor and featues, and not rely on string parsing. Alon -- To view, visit http://gerrit.ovirt.org/7549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib279ea8111825ec35a25f9ba6ee37b481ed4354f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
