Alex Lourie has posted comments on this change.
Change subject: packaging: Find and check JVM during setup (#834436)
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(2 inline comments)
I like it, only 2 minor comments.
....................................................
File packaging/fedora/setup/engine-setup.py
Line 1872:
controller.MESSAGES.append(output_messages.ERR_FAILED_START_SERVICE %
"rhevm-notifierd")
Line 1873:
Line 1874: def checkJavaVersion(version):
Line 1875: # Check that the version is supported:
Line 1876: if not version.startswith(basedefs.JAVA_VERSION):
I'd move these functions to common_utils or other helper file, so they could be
used later in other code.
Line 1877: logging.debug("Java version \"%s\" is not supported, it
should start with \"%s\"." % (version, basedefs.JAVA_VERSION))
Line 1878: return False
Line 1879:
Line 1880: # If we are here it is an acceptable java version:
Line 1893: logging.debug("The Java launcher \"%s\" isn't executable." %
javaLauncher)
Line 1894: return False
Line 1895:
Line 1896: # Invoke the Java launcher to check what is the version number:
Line 1897: javaProcess = subprocess.Popen([javaLauncher, "-version"],
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
utils.execCmd doesn't work for this?
Line 1898: javaOut, javaErr = javaProcess.communicate()
Line 1899: javaExit = javaProcess.wait()
Line 1900: if javaExit != 0:
Line 1901: logging.debug("The Java launcher \"%s\" fails with code %d."
% (javaLauncher, javaExit))
--
To view, visit http://gerrit.ovirt.org/7549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib279ea8111825ec35a25f9ba6ee37b481ed4354f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
