Mike Kolesnik has posted comments on this change.
Change subject: core: AddVmInterface Calls PlugUnplugCommand (#850854)
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java
Line 109:
ExecutionHandler.createDefaultContexForTasks(getExecutionContext()));
Line 110: if (!plugVmNicReturnValue.getSucceeded()) {
Line 111: getReturnValue().getExecuteFailedMessages().add("Failed
hot-plugging nic to VM");
Line 112:
getReturnValue().getCanDoActionMessages().addAll(plugVmNicReturnValue.getCanDoActionMessages());
Line 113:
getReturnValue().getCanDoActionMessages().remove(VdcBllMessages.VAR__ACTION__ADD.toString());
It would be better to use .name() as used in other places, since toString can
be overridden.
Line 114: getReturnValue().setCanDoAction(false);
Line 115: }
Line 116: return plugVmNicReturnValue.getSucceeded();
Line 117: }
--
To view, visit http://gerrit.ovirt.org/7542
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc4636c8003ea3fc170a13be96a3efb9dc8cca24
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
